Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG@14
PS9, Line 14: CQ-DEPEND=CL:*2843183
The syntax for this has changed:
It has to go on a separate line from the BUG, and it should look like this:
Cq-Depend: chrome-internal:2843183 (for internal) OR
Cq-Depend: chromium:1234567 (for public)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c36b132546049e3e775585c41164072f4ece73e
Gerrit-Change-Number: 40001
Gerrit-PatchSet: 9
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 07 Apr 2020 16:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment