Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31260 )
Change subject: coreboot: check Cr50 PM mode on normal boot ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31260/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31260/2//COMMIT_MSG@10 PS2, Line 10: dettected detected
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... File src/security/tpm/tss/vendor/cr50/cr50.h:
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... PS1, Line 91: A timeout of zero means : * "IMMEDIATE REBOOT".
Do you mean that the actual reset occurs in a deferred call only after completing the TPM command?
Yeah, which means in theory it's not quite "immediate". Without providing an argument to IMMEDIATE_RESET, it will trigger without a deferred call.
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/#/c/31260/1/src/security/tpm/tss/vendor/cr50/cr5... PS1, Line 79: cr50
Existing printk calls in this file used "cr50" - so I've changed those to to "Cr50" as well. […]
Ah - just match the file with lowercase then. We seem to have a mix of cr50, Cr50, CR50 throughout different code.