Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34459 )
Change subject: payloads/tianocore: Enable UEFIPayload
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34459/6/payloads/external/tianocore...
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/34459/6/payloads/external/tianocore...
PS6, Line 32: payload
why change this from 'version' to 'payload,' duplicating the choice above?
https://review.coreboot.org/c/coreboot/+/34459/6/payloads/external/tianocore...
PS6, Line 34: TIANOCORE_COREBOOTPAYLOAD
would it not be useful to be able to test a specific commit for UefiPayload as well?
Maybe we should rework this to have two options: master and revision, that apply for both Tianocore payloads - just point to different branches?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34459
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b7785fde9f4113b2cd91323ac0358b229c5a6e6
Gerrit-Change-Number: 34459
Gerrit-PatchSet: 6
Gerrit-Owner: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 25 Jul 2019 15:44:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
