build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 )
Change subject: mb/asrock/g41c-gs: Add the revision 1 variant ......................................................................
Patch Set 17:
(16 comments)
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c File src/mainboard/asrock/g41c-gs/gpio.c:
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 73: .gpio10 = GPIO_LEVEL_LOW, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 73: .gpio10 = GPIO_LEVEL_LOW, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 74: .gpio15 = GPIO_LEVEL_LOW, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 74: .gpio15 = GPIO_LEVEL_LOW, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 75: .gpio16 = GPIO_LEVEL_HIGH, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 75: .gpio16 = GPIO_LEVEL_HIGH, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 76: .gpio18 = GPIO_LEVEL_LOW, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 76: .gpio18 = GPIO_LEVEL_LOW, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 77: .gpio20 = GPIO_LEVEL_HIGH, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 77: .gpio20 = GPIO_LEVEL_HIGH, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 78: .gpio24 = GPIO_LEVEL_HIGH, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 78: .gpio24 = GPIO_LEVEL_HIGH, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 79: .gpio25 = GPIO_LEVEL_LOW, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 79: .gpio25 = GPIO_LEVEL_LOW, please, no spaces at the start of a line
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 80: .gpio27 = GPIO_LEVEL_LOW, code indent should use tabs where possible
https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c... PS17, Line 80: .gpio27 = GPIO_LEVEL_LOW, please, no spaces at the start of a line