Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35533 )
Change subject: mb/google/hatch: Support separate fixed PL1 setting for tablet mode
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35533/1//COMMIT_MSG@10
PS1, Line 10: but DPTF passive policy 1.0 cannot support it.
Is it okay to just change the PL1 setting in ASL without DPTF really knowing about it? What is the impact on DPTF?
Do you have a bug# where this was discussed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81c33f9df3e5431f04a08395141b5dc989474289
Gerrit-Change-Number: 35533
Gerrit-PatchSet: 1
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Comment-Date: Mon, 23 Sep 2019 04:53:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment