Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49025 )
Change subject: mb/clevo/cml-u: Rework Kconfig ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... PS3, Line 13: select HAVE_SPD_IN_CBFS
are there cml-u boards without soldered ram?
yes, n141cu for example.
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... PS3, Line 21: _OPTIONS
nit: I don't think we really need that suffix
we do, since it is already declared in Kconfig.name
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K... PS3, Line 21: onfig BOARD_CLEVO_L140CU_OPTIONS : bool : select BOARD_CLEVO_CMLU_COMMON : select EC_SYSTEM76_EC : select HAVE_SPD_IN_CBFS
just an idea: we could have a separate Kconfig for each variant in variants/<variant>/Kconfig where […]
I thought about that, but IMO the amount of config options is too small compared to the complexity this would add. It's not worth it. So I would like to leave it just here. It's not that this file is about to explode ;)