Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: [WIP] soc/amd/common: Access ACPI MMIO via proper symbols ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
(2 comments)
Only downside to this is that we're doing and extra read for every access to the bank instead of constants in the instruction stream.
Is it a downside? These sequences often do read-modify-writes so the address will appear multiple times in the instruction stream vs loading the base once into a register and using relative offseting. Depends of course of the arch how well it works but constants are not choice for PSP here anyway.
Sure. Depends on the compiler. I should have said "potential downside". Analysis would need to be done, but I'd also expect constant propagation to be used for immediates as well. In the end, I was just commenting on potential downsides. I don't have anything to suggest this is a bad change, though.