Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37643 )
Change subject: Documentation: Add proposal for firmware testing ......................................................................
Patch Set 7:
(7 comments)
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... File Documentation/technotes/2019-12-firmware-testing.md:
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 46: * nit: can we make this **bold** instead of *italic*; I think it would be easier to read. Thoughts?
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 58: must allow to specify DUTs and nit: must allow DUTs to specify
(minor wording issue)
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 134: The test system will be implemented in Go: Are we also going to adopt Golang's table driven test methodology? https://github.com/golang/go/wiki/TableDrivenTests
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 139: The build creates a host side test runner (native OS/arch) and a : variable number of DUT test runners (for all supported DUT OS/arch : pairs) that are provided to the DUT on some storage medium (e.g. USB : stick). In a fully automated environment this might require switching : USB ports between host and DUT. are we going to use https://github.com/mndrix/tap-go for golang TAP?
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 173: dita is this supposed to render as something in gitiles?
What do you think about making this in lucidcharts or something?
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 203: no not
https://review.coreboot.org/c/coreboot/+/37643/7/Documentation/technotes/201... PS7, Line 203: solution soultions