Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41793 )
Change subject: drivers/uart/acpi: Add new device driver for UART attached devices ......................................................................
Patch Set 1:
(1 comment)
There is a lot of duplication here between I2C/SPI/generic and now UART code. I'm going to look at extracting what I can but it needs some work to make all the implementations the same first.
https://review.coreboot.org/c/coreboot/+/41793/1/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/41793/1/src/drivers/uart/acpi/acpi.... PS1, Line 93: SLP_TYP_S3 I noticed most of these drivers are using a fixed '3' here which isn't going to be correct for AMD.