[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMS...

[Anil Kumar K (Code Review)]

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Paul Menzel, Kapil Porwal, Sridhar Siricilla, Anil Kumar K.

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74763 )

Change subject: soc/intel/meteorlake: Add config option to choose CSE FW sync in ROMSTAGE
......................................................................

Patch Set 4:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74763/comment/df9f1e6f_1baccf32 
PS1, Line 7: Add config option to choose CSE FW sync in ROMSTAGE
> > 72?

Done

Commit Message:

https://review.coreboot.org/c/coreboot/+/74763/comment/7756cbd4_bf6cca31 
PS3, Line 24: Change-Id: I8e603a2ecf1a67ee7c683b440072889d137f9de0
> Two Change-Ids?

fixed

File src/soc/intel/meteorlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/74763/comment/ac58add7_a1b2f438 
PS1, Line 131: SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE
> use the commit hash from Alder Lake where this changes had landed previously

Done

https://review.coreboot.org/c/coreboot/+/74763/comment/e2a76166_d82bc4dd 
PS1, Line 130: 
             : 	if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE))
             : 		cse_fw_sync();
> this gives the option to mainboard to choose - ROMSTAGE or RAMSTAGE depending on the config flag

Done

File src/soc/intel/meteorlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/74763/comment/bcbbf570_7c115e0b 
PS3, Line 131: if (!s3wake && CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE))
> Can we check SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE first? […]

Done