Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34920 )
Change subject: mainboards: Remove floating __PRE_RAM__ comments ......................................................................
mainboards: Remove floating __PRE_RAM__ comments
Change-Id: I110e54175a81b6a651213e0f18ddc1e3e71160cf Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34920 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/apple/macbook21/romstage.c M src/mainboard/asus/p5gc-mx/romstage.c M src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c M src/mainboard/ibase/mb899/romstage.c M src/mainboard/intel/d945gclf/romstage.c M src/mainboard/kontron/986lcd-m/romstage.c M src/mainboard/lenovo/t400/romstage.c M src/mainboard/lenovo/t60/romstage.c M src/mainboard/lenovo/x200/romstage.c M src/mainboard/lenovo/x201/romstage.c M src/mainboard/lenovo/x60/romstage.c M src/mainboard/lenovo/z61t/romstage.c M src/mainboard/packardbell/ms2290/romstage.c M src/mainboard/roda/rk886ex/romstage.c M src/mainboard/roda/rk9/romstage.c 15 files changed, 0 insertions(+), 30 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c index 1c84c84..e96de6f 100644 --- a/src/mainboard/apple/macbook21/romstage.c +++ b/src/mainboard/apple/macbook21/romstage.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <stdint.h> #include <cf9_reset.h> #include <device/pci_ops.h> diff --git a/src/mainboard/asus/p5gc-mx/romstage.c b/src/mainboard/asus/p5gc-mx/romstage.c index b076b9d..4e17d34 100644 --- a/src/mainboard/asus/p5gc-mx/romstage.c +++ b/src/mainboard/asus/p5gc-mx/romstage.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <cf9_reset.h> #include <device/pnp_ops.h> diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c index 2c7800f..bdb0a38 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <device/pci_ops.h> #include <device/pci_def.h> diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index c98556c..ab8282c 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <cf9_reset.h> #include <device/pnp_ops.h> diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c index 15a00cf..32b9a9f 100644 --- a/src/mainboard/intel/d945gclf/romstage.c +++ b/src/mainboard/intel/d945gclf/romstage.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <device/pci_def.h> #include <device/pci_ops.h> diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index b51e4b4..c940536 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -13,8 +13,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <stdint.h> #include <cf9_reset.h> #include <delay.h> diff --git a/src/mainboard/lenovo/t400/romstage.c b/src/mainboard/lenovo/t400/romstage.c index 43d6088..1b76318 100644 --- a/src/mainboard/lenovo/t400/romstage.c +++ b/src/mainboard/lenovo/t400/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <device/pci_ops.h> #include <console/console.h> #include <southbridge/intel/i82801ix/i82801ix.h> diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index cfe2d23..2817023 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <cf9_reset.h> #include <delay.h> diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c index afaa9aa..4382bc0 100644 --- a/src/mainboard/lenovo/x200/romstage.c +++ b/src/mainboard/lenovo/x200/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <device/pci_ops.h> #include <southbridge/intel/common/gpio.h> #include <southbridge/intel/i82801ix/i82801ix.h> diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index ae154e2..73f5bcc 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -16,8 +16,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <stdint.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index fc0c678..590e786 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <cf9_reset.h> #include <delay.h> diff --git a/src/mainboard/lenovo/z61t/romstage.c b/src/mainboard/lenovo/z61t/romstage.c index c31301e..4c487c0 100644 --- a/src/mainboard/lenovo/z61t/romstage.c +++ b/src/mainboard/lenovo/z61t/romstage.c @@ -15,8 +15,6 @@ * GNU General Public License for more details. */
-// __PRE_RAM__ means: use "unsigned" for device, not a struct. - #include <stdint.h> #include <cf9_reset.h> #include <delay.h> diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index 0ab5544..e2c5133 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -16,8 +16,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <stdint.h> #include <arch/io.h> #include <device/pci_ops.h> diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c index efd739c..02ee004 100644 --- a/src/mainboard/roda/rk886ex/romstage.c +++ b/src/mainboard/roda/rk886ex/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <stdint.h> #include <arch/io.h> #include <cf9_reset.h> diff --git a/src/mainboard/roda/rk9/romstage.c b/src/mainboard/roda/rk9/romstage.c index eaddaf9..497828b 100644 --- a/src/mainboard/roda/rk9/romstage.c +++ b/src/mainboard/roda/rk9/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */
-/* __PRE_RAM__ means: use "unsigned" for device, not a struct. */ - #include <arch/io.h> #include <device/pnp_ops.h> #include <device/pci_ops.h>