Attention is currently required from: Subrata Banik, Sridhar Siricilla, Kyösti Mälkki, Elyes Haouas.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72132 )
Change subject: soc/intel/common: Order the different types of cores based on APIC IDs
......................................................................
Patch Set 17:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72132/comment/8bfc2a72_2103f908
PS17, Line 13: cat
Not the cat, please.
https://review.coreboot.org/c/coreboot/+/72132/comment/30ee6d16_218fb5c7
PS17, Line 13: cpu$c
This variable is now undefined. Use glob (`cpu*`) instead.
https://review.coreboot.org/c/coreboot/+/72132/comment/165f4d22_f2a4202e
PS17, Line 37: grep . cat /sys/devices/system/cpu/cpu$c/topology/thread_siblings_list
ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72132
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21487a5eb0439ea0cb5976787d1769ee94777469
Gerrit-Change-Number: 72132
Gerrit-PatchSet: 17
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jan Samek
jan.samek@siemens.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 05 Apr 2023 08:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment