[coreboot-gerrit] Change in coreboot[master]: fw_config: Add firmware configuration interface

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )

Change subject: fw_config: Add firmware configuration interface
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h 
File src/include/fw_config.h:

https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@9 
PS4, Line 9: #include <static.h>
> er that is I thought I could use ramstage-c-deps when I was only building in ramstage when testing. […]

I went with the cheap fix because make is only making my head hurt.

https://review.coreboot.org/c/coreboot/+/41209/8/src/lib/fw_config.c 
File src/lib/fw_config.c:

https://review.coreboot.org/c/coreboot/+/41209/8/src/lib/fw_config.c@18 
PS8, Line 18: 	static uint32_t fw_config_value;
            : 	static bool fw_config_value_initialized;
I added some debug in the different stages to make sure this was working as expected.  it gets re-read once every stage.