Attention is currently required from: Arthur Heymans, Jincheng Li, Jérémy Compostella, Patrick Rudolph.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81133?usp=email )
Change subject: arch/x86/include/arch: Add feature check macros
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/81133/comment/e3aa654b_189c9862 :
PS1, Line 51: CPUID_FEATURE_MCE
It's unused. […]
This is referenced in GNR codes, but not critical. We can leave this to later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81133?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I014c25ced1dbe21f35486f8305b1de7669e932d0
Gerrit-Change-Number: 81133
Gerrit-PatchSet: 3
Gerrit-Owner: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 09:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment