Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155,H61} ......................................................................
Patch Set 29: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/Kconfig:
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 13: SERIRQ_CONTINUOUS_MODE If there is no SuperIO on LPC, I think you can drop this option
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 28: register "docking_supported" = "0" You can remove this, it defaults to zero already
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... File src/mainboard/ongy/h61m-s1/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/40813/29/src/mainboard/ongy/h61m-s1... PS29, Line 15: #include "acpi/superio.asl" The superio.asl file is included elsewhere already, so this is unnecessary