Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44085 )
Change subject: lib/string: Add standard strstr() function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44085/1/src/lib/string.c
File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/44085/1/src/lib/string.c@170
PS1, Line 170: if (!strncmp(haystack, needle, needle_len))
I still think you should just use strcmp() here so you can avoid the strlen(needle) as well, btw (already mentioned on other CL).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63e26e98ed2dd15542f81c0a3a5e353bb93b7350
Gerrit-Change-Number: 44085
Gerrit-PatchSet: 1
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 31 Jul 2020 20:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment