Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43549 )
Change subject: mb/google/volteer/var/voxel: change speaker smart amplifier to ALC1011
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43549/2/src/mainboard/google/voltee...
PS2, Line 16: option RT1011_ALC5682I_I2S 4
Caveh, is it okay to assign 4 to this codec/amplifier? If so, we need to add the program setting.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e7b829000a61a27f6a45a2688bb434e57f479a
Gerrit-Change-Number: 43549
Gerrit-PatchSet: 2
Gerrit-Owner: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 02:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment