Attention is currently required from: Michał Kopeć, Michael Niewöhner.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62495 )
Change subject: ec/clevo/it5570: Add Clevo EC implementation found on Clevo laptops
......................................................................
Patch Set 5:
(2 comments)
File src/ec/clevo/it5570/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/62495/comment/d8c9e52c_b900ecd5
PS5, Line 100: Method (I2ER, 1, NotSerialized)
Since this method is a sequence of writes to the same locations, shouldn't it be serialized?
https://review.coreboot.org/c/coreboot/+/62495/comment/15dd94eb_f951b170
PS5, Line 118: Method (I2EW, 2, NotSerialized)
Ditto
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62495
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07c7d1d4f86d764bd10cfa3b0da23d1116281f3b
Gerrit-Change-Number: 62495
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 02 May 2022 12:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment