Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46433 )
Change subject: mrc_cache: Add config SAVE_MRC_CACHE for checking TPM hash ......................................................................
Patch Set 2:
(3 comments)
Patch Set 1:
(3 comments)
Kinda weird that this is in a separate patch rather than together with the code that actually makes the option do something?
Kinda agree. I would merge with the next patch. Furquan had suggested that I have a CL first define the config. I'll follow up with him.
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 52: config SAVE_MRC_HASH
nit: I think it's a little nicer for namespacing to start this with "MRC", e.g. […]
Done.
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 53: bool
Currently with the way it's written, this feature needs to 'depends on VBOOT'. […]
Done
https://review.coreboot.org/c/coreboot/+/46433/1/src/drivers/mrc_cache/Kconf... PS1, Line 56:
nit: missing object
Done