Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43040 )
Change subject: ec/google/chromeec: Move if EC_GOOGLE_CHROMEEC to i2c_tunnel/Kconfig ......................................................................
ec/google/chromeec: Move if EC_GOOGLE_CHROMEEC to i2c_tunnel/Kconfig
This change moves `if EC_GOOGLE_CHROMEEC` from chromeec/Kconfig to chromeec/i2c_tunnel/Kconfig. This is done to make it clear that the Kconfig file in i2c_tunnel is sourced unconditionally, but the configs in i2c_tunnel/Kconfig are conditionally defined based on the evaluation of if condition.
This change addressed the feedback received on https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kco....
Change-Id: I66cd91d6b1813ff6d0fb7be719e2da65ac6ac23b Signed-off-by: Furquan Shaikh furquan@google.com --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/i2c_tunnel/Kconfig 2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/43040/1
diff --git a/src/ec/google/chromeec/Kconfig b/src/ec/google/chromeec/Kconfig index 4615878..638c011 100644 --- a/src/ec/google/chromeec/Kconfig +++ b/src/ec/google/chromeec/Kconfig @@ -197,8 +197,4 @@ Enable support for Chrome OS mode switches provided by the Chrome OS EC.
-if EC_GOOGLE_CHROMEEC - source "src/ec/google/chromeec/*/Kconfig" - -endif diff --git a/src/ec/google/chromeec/i2c_tunnel/Kconfig b/src/ec/google/chromeec/i2c_tunnel/Kconfig index 20169fd..e517a17 100644 --- a/src/ec/google/chromeec/i2c_tunnel/Kconfig +++ b/src/ec/google/chromeec/i2c_tunnel/Kconfig @@ -1,6 +1,11 @@ +if EC_GOOGLE_CHROMEEC + config EC_GOOGLE_CHROMEEC_I2C_TUNNEL bool depends on HAVE_ACPI_TABLES help This enables the Cros EC I2C tunnel driver that is required to fill the SSDT nodes for the I2C tunnel used by the mainboard. + +endif +