10 Dec
2020
10 Dec
'20
8:14 a.m.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48526 )
Change subject: util: Modify LPDDR4 spd_tools to generate SPDs for ADL boards ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48526/1/util/spd_tools/lp4x/gen_spd... File util/spd_tools/lp4x/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/48526/1/util/spd_tools/lp4x/gen_spd... PS1, Line 38: PlatformADL
Rather than adding another enum with same value as TGL, what do you think about reusing PlatformTGL […]
Hi Furquan,
Updated patch set 3 based on your suggestion, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48526
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4964ec28d74ab36c6b6f2e9dce6c923d1df95c84
Gerrit-Change-Number: 48526
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 07:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment