Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: mainboard/lenovo: Use the original hardware ids for keyboard/pointing ......................................................................
Patch Set 11:
(3 comments)
Looks like a good solution, thank you! Only some Kconfig nits...
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... File src/drivers/pc80/pc/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 24: "PS2 Keyboard ID" Why give it a prompt? If the default gives somebody trouble, IMO, the correct numbers should be added upstream, just like you do it here.
https://review.coreboot.org/c/coreboot/+/36371/11/src/drivers/pc80/pc/Kconfi... PS11, Line 33: dmesg logs on vendor BIOS. No idea, why you repeat the commit message here. Please describe the solution, not the (past) problem. A single line could be enough, e.g.
Mainboards can override the default to match vendor drivers and quirks.
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... File src/mainboard/lenovo/l520/Kconfig:
https://review.coreboot.org/c/coreboot/+/36371/11/src/mainboard/lenovo/l520/... PS11, Line 50: string You don't have to mention the type everytime, mainboards should just override the default value.