Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 11: Code-Review-1
(1 comment)
The content LGTM. Can you split the commit up into multiple commits?
* docs: fix typo * x230s: disable unconnected ports * x230/x230s: disable superseed capabilities for usb port 3 - there are no RXP/TXP lines (one line dts change) * x230/x230s: reorganisze baseboard & overrides devices (all remaining dts changes, since this is a no-op) * x230s: clean up early_init as similiar to x230.
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/11/src/mainboard/lenovo/x230/... PS11, Line 65: register "superspeed_capable_ports" = "0xf" please move superspeed_capable_ports into a seperate commit.