Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33844 )
Change subject: src/security/vboot: Add option to skip display init with vboot 2.0
......................................................................
Patch Set 7:
Hi Julius,
no worries. Build breakage is just noise, no harm done.
So I think the easiest fix would be to reupload the patch without the 'depends on' line and that should do the right thing everywhere. The alternative would be to switch all mainboard/SoC Kconfigs to control this via default rather than select, or to qualify the select with an 'if VBOOT_MAY_SKIP_DISPLAY_INIT'. But that just adds extra boilerplate to all those files so I think the former solution is probably better.
I still think this leaves us with three Kconfig options where only
one is needed. While they are all implemented in different places,
they could all be boiled down to forcing VB2_CONTEXT_DISPLAY_INIT.
I'll also take a look at Nico's suggestion.
I'll continue discussion there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icadad6da34dcb817af02868e89a94ea62dbfa7b3
Gerrit-Change-Number: 33844
Gerrit-PatchSet: 7
Gerrit-Owner: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Sachin Agrawal
sachin.agrawal@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Tue, 30 Jul 2019 07:25:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment