Attention is currently required from: Keith Hui.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78206?usp=email )
Change subject: nb/intel/sandybridge: Pre-render constants in MRC pei_data ......................................................................
Patch Set 4:
(1 comment)
File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/78206/comment/3461cbb8_a946cb03 : PS4, Line 404: struct pei_data pei_data;
The same thing can easily be achieved using a struct initialiser here: […]
This much easier to maintain, and also allows initialising fields whose value is always the result of some expression that can only be computed at runtime (e.g. `system_type`, `gbe_enable`).