Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803a
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33623/2/src/superio/fintek/common/fan_contro...
File src/superio/fintek/common/fan_control.h:
https://review.coreboot.org/#/c/33623/2/src/superio/fintek/common/fan_contro...
PS2, Line 69: #define FAN_FOLLOW_STEP 0
: #define FAN_FOLLOW_INTERPOLATION 1
You know, now that you highlighted it, I don't have code for this. […]
my guess would be that this is to select if the fan control should use the lower (or maybe upper) value when being between two boundaries or if it should do a linear interpolation between the values at the boundaries
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d336e76bccc38452b1b1aefef5d4a4f7ee129a8
Gerrit-Change-Number: 33623
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Jun 2019 17:15:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment
