[coreboot-gerrit] [L] Change in coreboot[main]: Introduce a coreboot Control Block (CCB)

[Arthur Heymans (Code Review)]

Attention is currently required from: Angel Pons, Felix Held, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass.

Arthur Heymans has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )

Change subject: Introduce a coreboot Control Block (CCB)
......................................................................

Patch Set 10:

(3 comments)

Patchset:

PS10:
> So long as you can access the flash early in the bootblock, then that can work. Reading the FMAP is not trivial and takes a small amount of time.
>
> We discussed making a 'fixed offset' in the flash an option.
>
> I would like to move forward with this...can someone perhaps persuade Julius to remove the -2 ?

Maybe address his comments?

I'm confused. FMAP is basically a fixed offset in the flash. How is it more complicated than having a different data structure in at a fixed offset?

File src/arch/x86/postcar.c:

https://review.coreboot.org/c/coreboot/+/77712/comment/97c9ca06_1d7a0538?usp... :
PS10, Line 21: console_init();
This is done with a reason: so you can debug cbmem init.

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/77712/comment/ba6a2083_e4413811?usp... :
PS10, Line 112: 	const char *value;
is this used?