12 May
2019
12 May
'19
11:53 a.m.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32761 )
Change subject: soc/intel/broadwell: Use the common cpu/intel/car romstage entry ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/32761/10/src/soc/intel/broadwell/romstage/Ma... File src/soc/intel/broadwell/romstage/Makefile.inc:
https://review.coreboot.org/#/c/32761/10/src/soc/intel/broadwell/romstage/Ma... PS10, Line 3: ../../../.. any reason to not use $(src) here as above?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32761
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95645271e0d93a97f544a1cc4e9a4320738e6a20
Gerrit-Change-Number: 32761
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Sun, 12 May 2019 18:53:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment