Attention is currently required from: Caveh Jalali, Paul Menzel, 陳建宏, YH Lin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48941 )
Change subject: drivers/genesyslogic/gl9763e: Fix boot on eMMC failed issue on Volteer
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/drivers/genesyslogic/gl9763e/gl9763e.c:
https://review.coreboot.org/c/coreboot/+/48941/comment/f8fb7a74_8a623927
PS3, Line 31: ver = pci_read_config32(dev, HW_VER_2);
: if ((ver & HW_VER_MASK) == REVISION_03) {
: /* Set clock source for RX path */
: pci_update_config32(dev, SD_CLKRX_DLY, ~CLK_SRC_MASK, AFTER_OUTPUT_BUFF);
: }
Is this specifically only to Volteer, or would this help other boards boot using those cards with GL9763E?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddb145ed6a9edb2d7a50248e64659cda78b88ae6
Gerrit-Change-Number: 48941
Gerrit-PatchSet: 3
Gerrit-Owner: 陳建宏
renius.chen@genesyslogic.com.tw
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ben Chuang
benchuanggli@gmail.com
Gerrit-CC: Chen Wisley
wisley.chen@quantatw.com
Gerrit-CC: HsuanYang Chen
ynop77@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: 陳建宏
renius.chen@genesyslogic.com.tw
Gerrit-Attention: YH Lin
yueherngl@chromium.org
Gerrit-Comment-Date: Fri, 08 Jan 2021 21:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment