[coreboot-gerrit] [M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message

[Kapil Porwal (Code Review)]

Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 )

Change subject: drivers/pc80/vga: Add API to write multi-line video message
......................................................................

Patch Set 8:

(1 comment)

File src/drivers/pc80/vga/vga.c:

https://review.coreboot.org/c/coreboot/+/71265/comment/fa9d2497_47d2388c 
PS3, Line 303: 	memcpy(str, string, strlen(string));
> > I dont think we should attempt to handle line wrapping and leave it to the creation of the string  […]

Yes, I agree.

I suggested this because of the below observations -
1. Characters post VGA_COLUMNS are suppressed (i.e. not printed).
2. We expect user of vga_write_text() to be aware of VGA_COLUMNS.