[coreboot-gerrit] Change in coreboot[master]: mb/intel/adlrvp: Add ADL-P romstage mainboard code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46091 )

Change subject: mb/intel/adlrvp: Add ADL-P romstage mainboard code
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46091/8/src/mainboard/intel/adlrvp/... 
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/46091/8/src/mainboard/intel/adlrvp/... 
PS8, Line 16: uintptr_t
> `size_t` is probably more appropriate here, for `spd_index` too

Ack

https://review.coreboot.org/c/coreboot/+/46091/8/src/mainboard/intel/adlrvp/... 
PS8, Line 23: 	spd_index = (board_id & BIT_4_0) & BIT_2_0;
> Hmm, this is essentially the same as `board_id & BIT_2_0`. […]

Ack