Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37562 )
Change subject: EC sync: Properly handle VBERROR return codes from vb2api_ec_sync ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... PS3, Line 71: EC_REBOOT_FLAG_ON_AP_SHUTDOWN Actually, sorry, on second thought this seems to be a problem. Did you test this? Does it still work?
I think you'll have to remove the ON_AP_SHUTDOWN (just pass 0 for flags) to make this work now. I think that should be fine -- I see no reason to sync with AP shutdown here.
https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... PS3, Line 72: BIOS_ERR nit: could also be EMERG, like die() uses