[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/rex/var/karis: Refactor SSD power sequencing

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun.

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80663?usp=email )

Change subject: mb/google/rex/var/karis: Refactor SSD power sequencing
......................................................................

mb/google/rex/var/karis: Refactor SSD power sequencing

Here are the two GPIOs to look for:
* GPP_A19: Power Enable
* GPP_A20: PERST

The flow is presented as `stage (GPIO PAD/Value)` for easy
understanding:

bootblock (A20/0, A19/1)
|
v
romstage (A20/1)

Ideally, we don't need SSD power sequencing at ramstage hence, removed
the logic from ramstage.

TEST=Able to build and boot google/karis using NVMe without any problems.
S0ix and read/write from/to SSD are also normal.

Change-Id: I79171a7830b75f5c20bbe30023f2814a62743a13
Signed-off-by: Subrata Banik 
---
M src/mainboard/google/rex/variants/karis/gpio.c
1 file changed, 6 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80663/1

diff --git a/src/mainboard/google/rex/variants/karis/gpio.c b/src/mainboard/google/rex/variants/karis/gpio.c
index db742d7..883bb95 100644
--- a/src/mainboard/google/rex/variants/karis/gpio.c
+++ b/src/mainboard/google/rex/variants/karis/gpio.c
@@ -39,10 +39,6 @@

/* GPP_A18 : [] ==> CAM_PSW_L */
    PAD_NC(GPP_A18, NONE),
-	/* GPP_A19 : [] ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_A19, 1, DEEP),
-	/* GPP_A20 : [] ==> SSD_PERST_L */
-	PAD_CFG_GPO_LOCK(GPP_A20, 1, LOCK_CONFIG),
    /* GPP_A21 : [] ==> PMCALERT */
    PAD_NC(GPP_A21, NONE),

@@ -367,10 +363,8 @@

/* Early pad configuration in bootblock */
 static const struct pad_config early_gpio_table[] = {
-	/* GPP_A19 : [] ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_A19, 0, DEEP),
    /* GPP_A20 : [] ==> SSD_PERST_L */
-	PAD_CFG_GPO(GPP_A20, 1, DEEP),
+	PAD_CFG_GPO(GPP_A20, 0, DEEP),

/* GPP_B16 : [] ==> SOC_HDMI_HPD_L */
    PAD_CFG_NF(GPP_B16, NONE, DEEP, NF2),
@@ -405,16 +399,14 @@
    PAD_CFG_GPO(GPP_C00, 1, DEEP),
    /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */
    PAD_CFG_GPO(GPP_C01, 0, DEEP),
+
+	/* GPP_A19 : [] ==> EN_PP3300_SSD */
+	PAD_CFG_GPO(GPP_A19, 1, DEEP),
 };

static const struct pad_config romstage_gpio_table[] = {
-	/* GPP_A19 : [] ==> EN_PP3300_SSD */
-	PAD_CFG_GPO(GPP_A19, 1, DEEP),
-
    /* GPP_B11 : [] ==> EN_FP_PWR */
    PAD_CFG_GPO(GPP_B11, 0, DEEP),
-	/* A20 : [] ==> SSD_PERST_L */
-	PAD_CFG_GPO(GPP_A20, 0, DEEP),
    /* GPP_C23 : [] ==> FP_RST_ODL */
    PAD_CFG_GPO(GPP_C23, 0, DEEP),
    /* GPP_C00 : [] ==> EN_TCHSCR_PWR */
@@ -423,6 +415,8 @@
    PAD_CFG_GPO(GPP_C01, 0, DEEP),
    /* GPP_D02 : Not Connected */
    PAD_NC(GPP_D02, NONE),
+	/* GPP_A20 : [] ==> SSD_PERST_L */
+	PAD_CFG_GPO(GPP_A20, 1, DEEP),
 };

const struct pad_config *variant_gpio_table(size_t *num)