Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47606 )
Change subject: nb/intel/sandybridge: Rename loop variable ......................................................................
nb/intel/sandybridge: Rename loop variable
The `discover_edges_real` function actually tests a range of values for DQS PI and evaluates how the system responds. Rename the loop variable.
Change-Id: I67390ba315d618d153f91c0e8a81db04ec8f63e1 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47606 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index b67eb56..893d6b2 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2310,14 +2310,14 @@
static int find_read_mpr_margin(ramctr_timing *ctrl, int channel, int slotrank, int *edges) { - int edge; + int dqs_pi; int stats[NUM_LANES][MAX_EDGE_TIMING + 1]; int lane;
- for (edge = 0; edge <= MAX_EDGE_TIMING; edge++) { + for (dqs_pi = 0; dqs_pi <= MAX_EDGE_TIMING; dqs_pi++) { FOR_ALL_LANES { - ctrl->timings[channel][slotrank].lanes[lane].rising = edge; - ctrl->timings[channel][slotrank].lanes[lane].falling = edge; + ctrl->timings[channel][slotrank].lanes[lane].rising = dqs_pi; + ctrl->timings[channel][slotrank].lanes[lane].falling = dqs_pi; } program_timings(ctrl, channel);
@@ -2337,7 +2337,7 @@ wait_for_iosav(channel);
FOR_ALL_LANES { - stats[lane][edge] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); + stats[lane][dqs_pi] = MCHBAR32(IOSAV_By_ERROR_COUNT_ch(channel, lane)); } }