Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Convert DDR4 MHz to MT/s correctly ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/4/src/soc/amd/picasso/dmi.c@1... PS4, Line 146: __attribute__ ((unused)) I would move all this into ddr4.c.