Name of user not set #1003143 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48627 )
Change subject: commonlib/region: Add null parameters handling
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48627/1//COMMIT_MSG@9
PS1, Line 9: Prevent NULL-pointer dereference of child or parent root_device parameter.
Yes, if you want a check an assert() would probably be more appropriate. […]
Thank You. So, I will abandon this change, as it is not needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9c2b4a3dc2f4f31a40fd045d1fa2d2d1df3eca
Gerrit-Change-Number: 48627
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Dec 2020 09:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1003143
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment