Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33394 )
Change subject: stage_cache: Make empty inline function if CONFIG_NO_STAGE_CACHE enable
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h
File src/include/stage_cache.h:
https://review.coreboot.org/#/c/33394/7/src/include/stage_cache.h@35
PS7, Line 35: CONFIG(CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM) \
: || CONFIG(RELOCATABLE_RAMSTAGE
I just went through the same thought process. This logic is mimicking the current set up. […]
Humm okay. Makes sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33394
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e10ef2d261f9b204cecbeae6f65fda037753534
Gerrit-Change-Number: 33394
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Jun 2019 19:31:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment