Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43908 )
Change subject: mb/intel/kblrvp: Factor out `HeciEnabled`
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43908/4/src/mainboard/intel/kblrvp/...
File src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43908/4/src/mainboard/intel/kblrvp/...
PS4, Line 133: does not match devicetree!
HECI is will function disable hence PCI enumeration is required bt setting below HeciEnabled config […]
Thanks for the explanation, will remove the FIXME
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67c958af2dc955d07b895dc93fbe2232dbd48d34
Gerrit-Change-Number: 43908
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Aug 2020 11:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment