[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Add SSDT generator for ChromeOS EC

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38541 )

Change subject: ec/google/chromeec: Add SSDT generator for ChromeOS EC
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38541/18/src/ec/google/chromeec/ec_... 
File src/ec/google/chromeec/ec_lpc.c:

https://review.coreboot.org/c/coreboot/+/38541/18/src/ec/google/chromeec/ec_... 
PS18, Line 463: 	pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info);
> Good catch, Nico, thank you!

Well, Matt already figured out that something is wrong with this patch. I just
had to narrow it down :)

Regarding a fix, I don't think we need the pnp_* stuff here. What this
effectively does is looking up a similar dev with `fn == 0`, then setting
`.ops` if it isn't already. Assuming the passed `dev` is always the correct
one, we could just override specific ops:

void google_ec_enable_extra(struct device *dev)
    {
            if (!dev->ops)
                    return;

dev->ops.init = lpc_ec_init;
            dev->ops.read_resources = lpc_ec_read_resources;
    }

Assuming we will be called with the correct dev amongst others, we could
add a check for `fn == 0`.