6 Mar
2020
6 Mar
'20
7:13 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39332 )
Change subject: sb/ibexpeak: Use .device for single PCI ID ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
I don't think there is much to gain from doing this, or am I mistaken?
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/thermal.c:
https://review.coreboot.org/c/coreboot/+/39332/3/src/southbridge/intel/ibexp... PS3, Line 63: .device = PCI_DID_INTEL_IBEXPEAK_THERMAL, What if another thermal device ID appears that can be handled by the same driver?
--
To view, visit https://review.coreboot.org/c/coreboot/+/39332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40c4447579cfbf2b9c52dcfaa34f34b22f75c89c
Gerrit-Change-Number: 39332
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Mar 2020 18:13:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment