Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46437 )
Change subject: mb/volteer: New variant for Volteer reworked with Dauntless
......................................................................
Patch Set 6:
(1 comment)
PTAL
https://review.coreboot.org/c/coreboot/+/46437/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46437/4/src/mainboard/google/voltee...
PS4, Line 289: .early_init = CONFIG(MAINBOARD_HAS_SPI_TPM_CR50),
These changes shouldn't be in the baseboard devicetree.cb. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdcd6c2ce3941c229518f21f0e479890b5d76dd1
Gerrit-Change-Number: 46437
Gerrit-PatchSet: 6
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Oct 2020 20:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment