[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/rauru: Add edp driver in mainboard

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )

Change subject: mb/google/rauru: Add edp driver in mainboard
......................................................................

Patch Set 4:

(6 comments)

File src/mainboard/google/rauru/chromeos.c:

https://review.coreboot.org/c/coreboot/+/85951/comment/54e27e7f_55c68d8d?usp... :
PS2, Line 60: struct lb_gpio edp_pwm_gpios[] = {
            : 		{GPIO_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"},
            : 	};
            : 	lb_add_gpios(gpios, edp_pwm_gpios, ARRAY_SIZE(edp_pwm_gpios));
            : 	struct lb_gpio backlight_gpios[] = {
            : 		{GPIO_AP_EDP_BKLTEN.id, ACTIVE_HIGH, -1, "backlight enable"},
            : 	};
> Use a single array.

Done

File src/mainboard/google/rauru/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/85951/comment/6f7b266e_80d151cd?usp... :
PS2, Line 12: Panel
> PANEL

Done

File src/mainboard/google/rauru/gpio.h:

https://review.coreboot.org/c/coreboot/+/85951/comment/bd325e96_2d80a157?usp... :
PS2, Line 18: #define GPIO_BL_PWM_1V8		GPIO(DISP_PWM)
> leave one blank line on above

Done

File src/mainboard/google/rauru/panel.c:

https://review.coreboot.org/c/coreboot/+/85951/comment/b057a967_b684a628?usp... :
PS2, Line 3: #include <boardid.h>
           : #include <cbfs.h>
           : #include <delay.h>
           : #include <fw_config.h>
           : #include <gpio.h>
           : #include <soc/ddp.h>
           : #include <soc/dsi.h>
           : #include <soc/gpio_common.h>
           : #include <soc/mtcmos.h>
> remove unused headers

Done

https://review.coreboot.org/c/coreboot/+/85951/comment/526daad6_d29f8e9c?usp... :
PS2, Line 39: Panel
> PANEL

Done

File src/mainboard/google/rauru/panel_navi.c:

https://review.coreboot.org/c/coreboot/+/85951/comment/8e155e1d_de98d9d6?usp... :
PS2, Line 3: #include <boardid.h>
           : #include <cbfs.h>
           : #include <delay.h>
           : #include <fw_config.h>
           : #include <gpio.h>
           : #include <soc/ddp.h>
           : #include <soc/dsi.h>
           : #include <soc/gpio_common.h>
           : #include <soc/mtcmos.h>
> please remove unused headers.

Done