Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede...
PS8, Line 41: .scl_lcnt = 176,
: .scl_hcnt = 95,
: .sda_hold = 36,
Audio is verified working, but these parameters are not electrically verified. […]
from the device spec:
CLKL SCL low time 500 ns
CLKH SCL high time 260 ns
the count high and low count I believe need to be calculated as 133(soc clk)* scl_low(or high)_time/Khz. Correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0516c7a8fee79ce17343a7f42895d6ef534fec9
Gerrit-Change-Number: 39285
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Mar 2020 16:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment