Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45643 )
Change subject: mb/google/volteer: Disable HybridStorageMode for Delbin
......................................................................
Patch Set 2:
Patch Set 2:
How about we change the baseboard (which is the default) to be 0, and only enable the option in variants that require it?
Agreed. I had this patch before "https://review.coreboot.org/c/coreboot/+/44261". But then we decided to work on dynamically detecting optane just like FSP. On checking FSP code they are doing it through HECI messages. Do you suggest i fix that old patch by adding dynamic detection or its not worth adding that code for volteer?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54fc78e3f888d4f2a02ba0ad6b9aef33eb872a9c
Gerrit-Change-Number: 45643
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 07:43:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment