Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )
Change subject: soc/intel/common: Select USE_LEGACY_8254_TIMER
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34709/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34709/2//COMMIT_MSG@9
PS2, Line 9: Always select USE_LEGACY_8254_TIMER if we know we have to.
It also selects USE_LEGACY_8254_TIMER in specific cases to prevent a hang.
Done
https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/34709/2/src/device/Kconfig@89
PS2, Line 89: select USE_LEGACY_8254_TIMER if SOC_INTEL_COMMON_BLOCK
It should be enabled for all Oproms, but we only support VGA Oproms in coreboot.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0c20255f661dd61edc3a7d15646b7447c4658e
Gerrit-Change-Number: 34709
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Aug 2019 13:05:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment