Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68116 )
Change subject: mb/google/skyrim: Override SPI flash bus speed
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/68116/comment/66c082a3_9f53871e
PS1, Line 96: default 0x5 if BOARD_GOOGLE_SKYRIM
: default 0xffffffff
Does this mean 100mhz only works on skyrim, and not any of the variants? […]
Even on skyrim, it works only on the board versions where the stubs to debug header is removed to meet SI requirements.
Similar exercise has to be done for other variants before enabling 100 MHz on them. Usually hardware team work along with the partner to measure the SI and then pass the bug to SW team to enable it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e8db22151fbc2db1f9e81b3644338348160736d
Gerrit-Change-Number: 68116
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Wed, 05 Oct 2022 20:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment