Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45229 )
Change subject: mb/supermicro/x11-lga1151-series: add x11ssh-f board as a variant ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-f.md:
https://review.coreboot.org/c/coreboot/+/45229/3/Documentation/mainboard/sup... PS3, Line 37: - S3 resume not working
I think this is because of FSP-M and SPS firmware. […]
I had never tested S3 with vendor firmware (or maybe I just don't remember anymore). Did you?
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 8: didn't check this, yet. was that just copied or is it verified with inteltool/intelp2m?
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 229: /*** XXX TODO XXX */ that can be dropped
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 32: # FIXME: find out why FSP crashes without this does that still apply?
https://review.coreboot.org/c/coreboot/+/45229/3/src/mainboard/supermicro/x1... PS3, Line 78: on disable it since there is no output