Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37187 )
Change subject: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T
......................................................................
Patch Set 2:
Patch Set 1:
Patch Set 1:
Patch Set 1:
(3 comments)
The FSP-T code is pretty bad/buggy especially in this regard. Did you test this?
Yes Arthur, we are testing across all FSP-T users inside Intel.
@Sheng is doing on IOT platform
@David is looking at server platform.
will get +1/+2 from them
Nice. Could you also have CB:36682 tested so FSP-T can dropped altogether?
Yes regarding BtG enabling, i have requested Sachin from intel to take a look and guide what needs to be done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a406fa0e2e62e3363c2960e173dc5f5f5ca0455
Gerrit-Change-Number: 37187
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Vincent Zimmer
vincent.zimmer@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 25 Nov 2019 08:04:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment