[coreboot-gerrit] Change in coreboot[master]: lib/prog_loaders.c: Add prog_locate_hook()

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30811 )

Change subject: lib/prog_loaders.c: Add prog_locate_hook()
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/30811/11/src/include/program_loadin... 
File src/include/program_loading.h:

https://review.coreboot.org/c/coreboot/+/30811/11/src/include/program_loadin... 
PS11, Line 144: validate
> imo line 'Hook .. proceed' already answers your comment.

Proceed from where to what? It's not clear; the statement ambiguous. I don't think it's too much to ask to improve clarity in comments for functions. FWIW, the hook doesn't have to verify anything either. It can do anything it wants from a policy perspective. How about the following?

The prog_locate_hook() is called prior to CBFS traversal. The hook can be used to implement policy that allows or prohibits further progress through prog_locate(). The type and name field within struct prog are the only valid fields. A 0 return value allows further progress while a non-zero return value prohibits further progress.