1 comment:
File src/include/program_loading.h:
Patch Set #11, Line 144: validate
imo line 'Hook .. proceed' already answers your comment.
Proceed from where to what? It's not clear; the statement ambiguous. I don't think it's too much to ask to improve clarity in comments for functions. FWIW, the hook doesn't have to verify anything either. It can do anything it wants from a policy perspective. How about the following?
The prog_locate_hook() is called prior to CBFS traversal. The hook can be used to implement policy that allows or prohibits further progress through prog_locate(). The type and name field within struct prog are the only valid fields. A 0 return value allows further progress while a non-zero return value prohibits further progress.
To view, visit change 30811. To unsubscribe, or for help writing mail filters, visit settings.